Add ExtraAttributes to Attributes #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses go-cas#2
30fd840 to
c3b5675
Compare
|
It looks like they've changed the specification, where they used to have cas:attributes>cas:userAttributes which could contain xs:any they've now just got xs:any inside the cas:attributes type. Thank you for this. |
geoffgarside
added a commit
that referenced
this pull request
Sep 30, 2015
Update XML Service Response support for latest CAS SAML extra attributes. The [specification][spec] for the SAML CAS response attributes has been changed such that the `cas:attributes` XML element no longer mentions the `cas:userAttributes` element. The contents of the `cas:userAttributes` element can now be located directly in the `cas:attributes` element. [spec]: http://jasig.github.io/cas/4.1.x/protocol/CAS-Protocol-Specification.html#saml-cas-response-attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2