feat: Add mcp.json to Visual Studio gitignore exceptions #4735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mcp's are becoming more common, sharing a workspace configuration of mcp servers is becoming more and more common with the mcp.json file. (https://code.visualstudio.com/docs/copilot/customization/mcp-servers#_add-an-mcp-server) Adding this file as an exclusion to the default template so that it can be utilized by the editors and shared via source control. This file can also be picked up by Visual Studio as seen [here](https://learn.microsoft.com/visualstudio/ide/mcp-servers?view=vs-2022&WT.mc_id=8B97120A00B57354#file-locations-for-automatic-discovery-of-mcp-configuration)
There was a problem hiding this comment.
Pull Request Overview
This PR adds an exception for the mcp.json file in the Visual Studio gitignore template to support sharing Model Context Protocol (MCP) server configurations. The change allows the .vscode/mcp.json file to be tracked in version control alongside other VS Code workspace configuration files.
- Adds
!.vscode/mcp.jsonas an exception to the gitignore pattern - Enables sharing of MCP server configurations across development teams
- Aligns with existing patterns for other VS Code configuration files
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
TBH I'd go as far as removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
As mcp's are becoming more common, sharing a workspace configuration of mcp servers is becoming more and more common with the mcp.json file. (https://code.visualstudio.com/docs/copilot/customization/mcp-servers#_add-an-mcp-server)
Adding this file as an exclusion to the default template so that it can be utilized by the editors and shared via source control.
This file can also be picked up by Visual Studio as seen here
Links to documentation supporting these rule changes
VSCode itself commits this file: https://github.com/microsoft/vscode/blob/main/.vscode/mcp.json
If this is a new template
Link to application or project’s homepage: TODO
Merge and Approval Steps