+
Skip to content

Remove Cursor files from Python gitignore #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

injust
Copy link
Contributor

@injust injust commented Jul 13, 2025

This reverts commit 9cabb94.

Reasons for making this change

#4633 was a bad change. Cursor rules belong in a global gitignore file, and were added to one in #4639.

Links to documentation supporting these rule changes

#4633

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and Approval from one of the maintainers

@injust injust marked this pull request as ready for review July 13, 2025 19:40
@injust injust requested a review from a team as a code owner July 13, 2025 19:40
Copy link
Collaborator

@dooleydevin dooleydevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! This preceded the global ignore file and I was fine including it at that time. Agree that this does not belong here 🙇

Thanks for the contribution!

@dooleydevin dooleydevin merged commit b46f89d into github:main Jul 14, 2025
@injust injust deleted the python-revert-cursor branch July 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载