-
Notifications
You must be signed in to change notification settings - Fork 97
build(deps-dev): bump typescript-eslint from 8.43.0 to 8.45.0 #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8fb3846
to
34e4f8c
Compare
The function that is run on each commit is not `async` and therefore does not need to be awaited, either. This will be pointed out by `typescript-eslint` v8.45.0, with the following symptom: lib/ci-helper.ts Error: 1023:17 error Unexpected iterable of non-Promise (non-"Thenable") values passed to promise aggregator @typescript-eslint/await-thenable So let's avoid that problem before upgrading. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When awaiting multiple asynchronous functions to complete via the `Promise.all()` call, the assumption is that those functions are marked up as `async`, too. Otherwise `typescript-eslint` v8.45.0 would complain about `Promise.all()` being unnecessary, like this: lib/delete-ci-test-branches.ts Error: 117:9 error Unexpected iterable of non-Promise (non-"Thenable") values passed to promise aggregator @typescript-eslint/await-thenable The underlying reason why that function was not marked up as `async` is that the `graphql()` call returns `GraphQlResponse<ResponseData>`, which is not immediately identified as a `Promise` (but it is). So let's `await` that call, _and_ mark the function as `async`, _before_ upgrading to `typescript-eslint` v8.45.0. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Bumps [typescript-eslint](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/typescript-eslint) from 8.43.0 to 8.45.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-eslint/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.45.0/packages/typescript-eslint) --- updated-dependencies: - dependency-name: typescript-eslint dependency-version: 8.45.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
34e4f8c
to
e10290f
Compare
dscho
approved these changes
Oct 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 7, 2025
….43.0 to 8.45.0 (#2022), 2025-10-07))
github-actions bot
pushed a commit
to Bassamx93/gitgitgadget
that referenced
this pull request
Oct 7, 2025
….43.0 to 8.45.0 (gitgitgadget#2022), 2025-10-07))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
javascript
Pull requests that update Javascript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps typescript-eslint from 8.43.0 to 8.45.0.
Release notes
Sourced from typescript-eslint's releases.
... (truncated)
Changelog
Sourced from typescript-eslint's changelog.
Commits
255e9e2
chore(release): publish 8.45.0c198052
chore(release): publish 8.44.177056f7
chore(release): publish 8.44.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)