+
Skip to content

Conversation

jjerphan
Copy link

@jjerphan jjerphan commented Aug 25, 2025

cc: "D. Ben Knoble" ben.knoble@gmail.com

Add the short form `-u` as an alias for `--set-upstream`
in `git pull`, similarly to `git push` which supports both forms.

This allows users to use `git pull -u <remote> <branch>` as a
shorter alternative to `git pull --set-upstream <remote> <branch>`.

One test is included to verify that the short form works
correctly and set the upstream configuration as expected.

Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
Copy link

Welcome to GitGitGadget

Hi @jjerphan, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that either:

  • Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
  • Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net>

NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description,
because it will result in a malformed CC list on the mailing list. See
example.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

@jjerphan jjerphan marked this pull request as ready for review August 25, 2025 15:49
@Ikke
Copy link
Contributor

Ikke commented Aug 25, 2025

/allow

Copy link

User jjerphan is now allowed to use GitGitGadget.

@jjerphan
Copy link
Author

/preview

Copy link

Preview email sent as pull.2037.git.git.1756147422766.gitgitgadget@gmail.com

@jjerphan
Copy link
Author

/submit

Copy link

Submitted as pull.2037.git.git.1756147789443.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-2037/jjerphan/pull/set-upstream-short-option-v1

To fetch this version to local tag pr-git-2037/jjerphan/pull/set-upstream-short-option-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-2037/jjerphan/pull/set-upstream-short-option-v1

Copy link

On the Git mailing list, "D. Ben Knoble" wrote (reply to this):

On Mon, Aug 25, 2025 at 2:50 PM Julien Jerphanion via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Julien Jerphanion <git@jjerphan.xyz>
>
> Add the short form `-u` as an alias for `--set-upstream`
> in `git pull`, similarly to `git push` which supports both forms.
>
> This allows users to use `git pull -u <remote> <branch>` as a
> shorter alternative to `git pull --set-upstream <remote> <branch>`.
>
> One test is included to verify that the short form works
> correctly and set the upstream configuration as expected.
>
> Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
> ---
>     Add -u short option for git pull
>
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2037%2Fjjerphan%2Fpull%2Fset-upstream-short-option-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2037/jjerphan/pull/set-upstream-short-option-v1
> Pull-Request: https://github.com/git/git/pull/2037
>
>  builtin/pull.c          | 2 +-
>  t/t5553-set-upstream.sh | 7 +++++++
>  2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/builtin/pull.c b/builtin/pull.c
> index 5ebd5296207..e09f2963f78 100644
> --- a/builtin/pull.c
> +++ b/builtin/pull.c
> @@ -254,7 +254,7 @@ static struct option pull_options[] = {
>                 0),
>         OPT_BOOL(0, "show-forced-updates", &opt_show_forced_updates,
>                  N_("check for forced-updates on all updated branches")),
> -       OPT_PASSTHRU(0, "set-upstream", &set_upstream, NULL,
> +       OPT_PASSTHRU('u', "set-upstream", &set_upstream, NULL,

Don't forget to update the docs ;)

>                 N_("set upstream for git pull/fetch"),
>                 PARSE_OPT_NOARG),
>
> diff --git a/t/t5553-set-upstream.sh b/t/t5553-set-upstream.sh
> index 70e3376d31b..b4dd7c62ce9 100755
> --- a/t/t5553-set-upstream.sh
> +++ b/t/t5553-set-upstream.sh
> @@ -124,6 +124,13 @@ test_expect_success 'pull --set-upstream upstream main sets branch main but not
>         check_config_missing other
>  '
>
> +test_expect_success 'pull -u upstream main sets branch main but not other' '
> +       clear_config main other &&
> +       git pull --no-rebase -u upstream main &&
> +       check_config main upstream refs/heads/main &&
> +       check_config_missing other
> +'
> +
>  test_expect_success 'pull --set-upstream main:other2 does not set the branch other2' '
>         clear_config other2 &&
>         git pull --no-rebase --set-upstream upstream main:other2 &&
>
> base-commit: 1fa68948c3d76328236cac73d2adf33c905bd8e3
> --
> gitgitgadget
>


-- 
D. Ben Knoble

Copy link

User "D. Ben Knoble" <ben.knoble@gmail.com> has been added to the cc: list.

Copy link

On the Git mailing list, Junio C Hamano wrote (reply to this):

"Julien Jerphanion via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Julien Jerphanion <git@jjerphan.xyz>
>
> Add the short form `-u` as an alias for `--set-upstream`
> in `git pull`, similarly to `git push` which supports both forms.
>
> This allows users to use `git pull -u <remote> <branch>` as a
> shorter alternative to `git pull --set-upstream <remote> <branch>`.

The above explains what it does.  It does not justify why it is
needed.  Surely it may allow them to type less, but is it something
they would do very often, like every other day or even twice an
hour?  If not, should 'set-upstream' squat on a short-and-sweet 'u',
robbing it from future developers to use it for more useful purpose?

Copy link

On the Git mailing list, Julien Jerphanion wrote (reply to this):

-------- Original Message --------
On 8/26/25 16:51, Junio C Hamano <gitster@pobox.com> wrote:

>  "Julien Jerphanion via GitGitGadget" <gitgitgadget@gmail.com>
>  writes:
>  
>  > From: Julien Jerphanion <git@jjerphan.xyz>
>  >
>  > Add the short form `-u` as an alias for `--set-upstream`
>  > in `git pull`, similarly to `git push` which supports both forms.
>  >
>  > This allows users to use `git pull -u <remote> <branch>` as a
>  > shorter alternative to `git pull --set-upstream <remote> <branch>`.
>  
>  The above explains what it does.  It does not justify why it is
>  needed.  Surely it may allow them to type less, but is it something
>  they would do very often, like every other day or even twice an
>  hour?  If not, should 'set-upstream' squat on a short-and-sweet 'u',
>  robbing it from future developers to use it for more useful purpose?
>  
>

Hello,

Before all, thank you for maintaining git!

Having this shortcut would be really useful for some use cases where one needs to pull locally branches from forks before updating them and pushing them again on the fork instead than on the upstream project (typical use case for conda-forge's feedstocks).

Julien.

Copy link

On the Git mailing list, Junio C Hamano wrote (reply to this):

Julien Jerphanion <git@jjerphan.xyz> writes:

[jc: line-wrapped an overly long single line]

> Having this shortcut would be really useful for some use cases
> where one needs to pull locally branches from forks before
> updating them and pushing them again on the fork instead than on
> the upstream project (typical use case for conda-forge's
> feedstocks).

Sorry, do you mean that you stay on a single branch, and then you
would pull from one place with "git pull -u" followed by "git push"
to push back there, and repeat that for other places, practically
redefining the meaning of the "upstream" to "the last remote
repository I pulled from and I am supposed to push to that remote
and nowhere else in my workflow"?

Copy link

On the Git mailing list, Julien Jerphanion wrote (reply to this):

-------- Original Message --------
On 9/18/25 02:32, Junio C Hamano <gitster@pobox.com> wrote:

>  Julien Jerphanion <git@jjerphan.xyz> writes:
>  
>  [jc: line-wrapped an overly long single line]
>  
>  > Having this shortcut would be really useful for some use cases
>  > where one needs to pull locally branches from forks before
>  > updating them and pushing them again on the fork instead than on
>  > the upstream project (typical use case for conda-forge's
>  > feedstocks).
>  
>  Sorry, do you mean that you stay on a single branch, and then you
>  would pull from one place with "git pull -u" followed by "git push"
>  to push back there, and repeat that for other places, practically
>  redefining the meaning of the "upstream" to "the last remote
>  repository I pulled from and I am supposed to push to that remote
>  and nowhere else in my workflow"?
>  
>

More or less, I was referring to the official repository in
such workflows as `upstream`.

I would also sporadically fetch and pull from `upstream`,
but I would not set local branches to tracks remote
branches there.

As a user, I find that having `-u` usable for the `pull`
command would be consistent and expected given that
it is present for other commands already.

Thank you for spending time considering this addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载