-
Notifications
You must be signed in to change notification settings - Fork 179
wip style update #3664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jeffbaumes
wants to merge
22
commits into
v4-integration
Choose a base branch
from
v5-wip-style
base: v4-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
wip style update #3664
+9,195
−5,666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the @girder/pug-lint-config package
Minor UI fixes
Fix scrolling on login
Remove spurious leading period from class name
This setting is core.download_shown and can be "all" (default), "user", "admin", or "none". If not all, download controls are only shown for a subset of users -- any logged in user, only those who are admins, or no one. This doesn't effect endpoints, just what is shown in the UI.
Add a show-download setting that defaults to all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch merges the
v4-integration
andwip-style
branches and reconciles the new vite build with the tailwind-based experimental UI. Instead of hard coding the development-oriented version of Tailwind from CDN, this now does it the more official way with atailwind.config.js
file and importing the Tailwind base CSS.I used the Tailwind 3.4 docs using the "Tailwind CLI" instructions for installation. There is now a Tailwind 4 but things were built based of Tailwind 3 so I'm not sure if Tailwind 4 works.
Note the use of
in
tailwind.config.js
. This will pull in all classes without Tailwind's normal tree-shaking , which is safest since plugins might use arbitrary other Tailwind classes.Attn @zachmullen @manthey @naglepuff