+
Skip to content

Conversation

cameronwhite
Copy link
Contributor

As bug #1258 notes, we also should set up tests for long values as well

Bug: #1257

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

badcel
badcel previously requested changes May 23, 2025
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good already can you add some more data to the tests? See comment.

@badcel badcel linked an issue May 23, 2025 that may be closed by this pull request
This fixes errors when accessing uint64 properties.

Bug: #1257
@cameronwhite cameronwhite force-pushed the fix/uint64-properties branch from a3e8820 to ce0d7ed Compare May 24, 2025 00:42
@badcel badcel dismissed their stale review May 24, 2025 04:50

Looks good, thank you 👍

@badcel badcel merged commit 9f04132 into main May 24, 2025
3 checks passed
@badcel badcel deleted the fix/uint64-properties branch May 24, 2025 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UInt64 properties produce errors at runtime

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载