+
Skip to content

Add GirCore.Secret with libsecret support #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Conversation

czirok
Copy link
Contributor

@czirok czirok commented Apr 19, 2025

  • [X ] I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Hi,

I've added support for Secret-1.gir, along with a demo application that includes:

  • Access Token
  • Microsoft Identity

Please let me know if anything needs to be improved or adjusted.

@badcel
Copy link
Member

badcel commented Apr 19, 2025

Thanks, I need to take a detailed look at your PRs this will take some time.

@czirok
Copy link
Contributor Author

czirok commented Apr 19, 2025

You're very welcome!

A small note to help with reading: treat it as a Secure Storage Storyboard, and go through it in this order:

  • Program.cs
  • ToSchemaHashTable.cs
  • ToAttributesHashTable.cs
  • AccessToken.Tab.cs
  • MicrosoftIdentity.Tab.cs

@czirok czirok force-pushed the Secret-1.gir branch 6 times, most recently from 52cd220 to 82a7e92 Compare April 22, 2025 06:39
@badcel
Copy link
Member

badcel commented Apr 22, 2025

Don't work to much on this PR. First the Gir files must be updated on the main branch.

Afterwards this PR must be rebased again.

There probably don't need to be any unit tests. There are only tests that confirm that certain generator scenarios are supported. Current library specific tests are mostly legacy code.

If "Secret-1.gir" is available this PR should probably only include the absolute minimum to create and release the bindings.

I think if this is done there could already be a 0.7.0-Preview.1 release so users can benefit from GNOME SDK 48 and the new Secret-1 binding.

Where we put some helper methods needs to be figured out separately.

Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

I just merged the pull requests which brings in the "Secret-1.gir" file into the main branch.

To get this PR merged please rebase onto current main and see my comments.

@czirok
Copy link
Contributor Author

czirok commented Apr 24, 2025

Done, rebased and updated.

@czirok czirok requested a review from badcel April 24, 2025 11:08
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But it is not based on the latest commit. It misses the GNOME SDK 48 commits.

You probably missed to fetch the latest commits before doing the rebase.

@badcel
Copy link
Member

badcel commented Apr 25, 2025

If you now squash the last two commits and preserve the initial commit message we are all set! 🚀

Sorry for the inconvenience.

@czirok
Copy link
Contributor Author

czirok commented Apr 25, 2025

Done, and no worries at all! 🚀😊

@badcel
Copy link
Member

badcel commented Apr 25, 2025

Now you updated the gir-files git submodule (see files changed). I would recommend soft resetting the last commit and unstaging the change of the gir-files directory and committing and pushing again.

Perhaps make a backup branch beforehand to not loose your changes in case something goes wrong.

To ensure you are on the correct gir-files commit for the future you can check github: https://github.com/gircore/gir.core/tree/main/ext and just checkout the number at the end of the folder name (currently 5bce3d6).

@czirok czirok requested a review from badcel April 30, 2025 19:13
@czirok czirok changed the title Add Gir.Core.Secret package and demo for secure storage via libsecret Add GirCore.Secret with libsecret support Apr 30, 2025
@badcel badcel merged commit 5e4f19c into gircore:main May 1, 2025
3 checks passed
@badcel
Copy link
Member

badcel commented May 1, 2025

Thanks for your work! It is great to have support for libsecret 🚀

One more explanation: I merged the PR despite that it was still not properly synchronized with main. In the beginning of the project I lost data because I merged a PR that was missing commits. This is why I enabled this rule and GitHub was still complaining for your PR. As there was no overlap with the missing commit it was fine to merge.

I would recommend making you more familiar with git so you have full control over your version history even if submodules are involved.

@badcel
Copy link
Member

badcel commented May 1, 2025

@czirok I have another idea what could be the root cause of the issue: You are working on a fork of GirCore.
So the main branch of your fork must first be updated to match the main branch of GirCore before rebasing your own feature branch on the main branch of your fork.

You can do this either via the GitHub homepage directly or you need to handle different git origins and do it manually.

@badcel badcel linked an issue May 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider wrapping libsecret
2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载