-
Notifications
You must be signed in to change notification settings - Fork 37
Add GirCore.Secret with libsecret support #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks, I need to take a detailed look at your PRs this will take some time. |
You're very welcome! A small note to help with reading: treat it as a Secure Storage Storyboard, and go through it in this order:
|
52cd220
to
82a7e92
Compare
Don't work to much on this PR. First the Gir files must be updated on the main branch. Afterwards this PR must be rebased again. There probably don't need to be any unit tests. There are only tests that confirm that certain generator scenarios are supported. Current library specific tests are mostly legacy code. If "Secret-1.gir" is available this PR should probably only include the absolute minimum to create and release the bindings. I think if this is done there could already be a 0.7.0-Preview.1 release so users can benefit from GNOME SDK 48 and the new Secret-1 binding. Where we put some helper methods needs to be figured out separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
I just merged the pull requests which brings in the "Secret-1.gir" file into the main branch.
To get this PR merged please rebase onto current main and see my comments.
Done, rebased and updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But it is not based on the latest commit. It misses the GNOME SDK 48 commits.
You probably missed to fetch the latest commits before doing the rebase.
If you now squash the last two commits and preserve the initial commit message we are all set! 🚀 Sorry for the inconvenience. |
Done, and no worries at all! 🚀😊 |
Now you updated the gir-files git submodule (see files changed). I would recommend soft resetting the last commit and unstaging the change of the gir-files directory and committing and pushing again. Perhaps make a backup branch beforehand to not loose your changes in case something goes wrong. To ensure you are on the correct gir-files commit for the future you can check github: https://github.com/gircore/gir.core/tree/main/ext and just checkout the number at the end of the folder name (currently |
Thanks for your work! It is great to have support for libsecret 🚀 One more explanation: I merged the PR despite that it was still not properly synchronized with I would recommend making you more familiar with git so you have full control over your version history even if submodules are involved. |
@czirok I have another idea what could be the root cause of the issue: You are working on a fork of GirCore. You can do this either via the GitHub homepage directly or you need to handle different git origins and do it manually. |
Hi,
I've added support for
Secret-1.gir
, along with a demo application that includes:Please let me know if anything needs to be improved or adjusted.