-
Notifications
You must be signed in to change notification settings - Fork 41
Add and use in tests platform attribute #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d541de
to
a75765c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good work thank you. 🚀
I have some minor remarks which should improve mainly the maintenance aspect of the code.
After those changes it should be ready to go.
Please amend your changes to avoid creating new commits.
Please confirm that you are fine to release the code either under MIT or LGPL license in the body of your PR text.
815c77b
to
04601ad
Compare
I think I addressed all the comments |
04601ad
to
c58859e
Compare
c58859e
to
c124bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work 👍
I need to check it on the PC one more if the solution file is working like intended (I did the review on mobile).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the solution in Rider. I think it is not necessary to change the GirCore.sln
file. The new attribute is part of the Test projects through the Directory.Build.props
file already. This would match how it is done in the "Generation" folder where a "Shared" folder exists in the file system, too.
c124bb9
to
0f1cec1
Compare
I don't know how or why it was added - I blame Rider 😄. I removed it. |
Thanks a lot for your contribution it improves the readability of the tests quite a bit 🚀. |
Uh oh!
There was an error while loading. Please reload this page.