+
Skip to content

Conversation

UrtsiSantsi
Copy link
Contributor

@UrtsiSantsi UrtsiSantsi commented Apr 18, 2025

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

@UrtsiSantsi UrtsiSantsi force-pushed the platform_attribute branch 4 times, most recently from 3d541de to a75765c Compare April 18, 2025 09:09
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good work thank you. 🚀

I have some minor remarks which should improve mainly the maintenance aspect of the code.

After those changes it should be ready to go.

Please amend your changes to avoid creating new commits.

Please confirm that you are fine to release the code either under MIT or LGPL license in the body of your PR text.

@UrtsiSantsi UrtsiSantsi force-pushed the platform_attribute branch 3 times, most recently from 815c77b to 04601ad Compare April 18, 2025 19:12
@UrtsiSantsi
Copy link
Contributor Author

I think I addressed all the comments

Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work 👍

I need to check it on the PC one more if the solution file is working like intended (I did the review on mobile).

@badcel badcel linked an issue Apr 19, 2025 that may be closed by this pull request
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the solution in Rider. I think it is not necessary to change the GirCore.sln file. The new attribute is part of the Test projects through the Directory.Build.props file already. This would match how it is done in the "Generation" folder where a "Shared" folder exists in the file system, too.

@UrtsiSantsi
Copy link
Contributor Author

I checked the solution in Rider. I think it is not necessary to change the GirCore.sln file. The new attribute is part of the Test projects through the Directory.Build.props file already. This would match how it is done in the "Generation" folder where a "Shared" folder exists in the file system, too.

I don't know how or why it was added - I blame Rider 😄. I removed it.

@badcel badcel merged commit f9b7dc3 into gircore:main Apr 21, 2025
3 checks passed
@badcel
Copy link
Member

badcel commented Apr 21, 2025

Thanks a lot for your contribution it improves the readability of the tests quite a bit 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MSTest: use attribute to filter operating system

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载