GridView Sample with StringList and CustomObject ListStore #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kashifsoofi
commented
Feb 21, 2024
- I agree that my contribution may be licensed either under MIT or any version of LGPL license.
badcel
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Thank you for your contribution.
When I run the sample the first time the SVG files where not displayed. This happened because my working directory was inside the bin/debug folder which does not contain the Resources folder.
Perhaps adding something like this to the csproj file is a good idea as the path is a relative one:
<ItemGroup>
<None Include="$(ProjectDir)Resources\**" CopyToOutputDirectory="PreserveNewest" />
</ItemGroup>- Can you confirm that the used SVG files are allowed to be used?
- Can you add some link to the original SVG source in the source code as a comment so it is easy to find the original files?
04c1881 to
523feb0
Compare
523feb0 to
106de9e
Compare
|
Project file updated, I have added README.md with links to the SVG files.
|
badcel
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.