write: fix handling of forward references in expressions #777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b64ed6 to
5947ba7
Compare
Writing a reference can fail when: - an expression contains a forward reference to a unit entry - an expression or attribute contains a reference to a deleted entry Return an error instead of hitting a debug assertion or writing a zero. There was code that was meant to handle this already for forward references, but it was wrong.
5947ba7 to
4b44f13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing a reference can fail when:
Return an error instead of hitting a debug assertion or writing a zero.
There was code that was meant to handle this already for forward references,
but it was wrong.