Add constants obsolete after DWARF 1.1 #775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The DWARF 1.1 specification includes some constants which are only relevant in that spec, and became obsolete in the later revisions of the spec. * Currently the gimli does not include these constants because since DWARF 1.1 is a different structure and rarely relevant it does not support parsing of DWARF 1.1. * However DWARF 1.1 is relevant to the decomp community. Since decomp tooling wants to depend on gimli anyways for DWARF 2+, it would be nice if it could also use at least gimli data structures for DWARF 1.1 rather than having to write something entirely bespoke. Including the constants unique to DWARF 1.1 helps with that. * This is unlikely to cause much confusion about what is supported since anyone who runs into DWARF 1.1 in practice is probably already deep in the weeds.
philipc
reviewed
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DWARF 1.1 specification includes some constants which are only relevant in that spec, and became obsolete in the later revisions of the spec.
Currently the gimli does not include these constants because since DWARF 1.1 is a different structure and rarely relevant it does not support parsing of DWARF 1.1.
However DWARF 1.1 is relevant to the decomp community. Since decomp tooling wants to depend on gimli anyways for DWARF 2+, it would be nice if it could also at least use gimli data structures for DWARF 1.1 rather than having to write something bespoke. Including the constants unique to DWARF 1.1 helps with that.
This is unlikely to cause much confusion about what is supported since anyone who runs into DWARF 1.1 in practice is probably already deep in the weeds.
The added values can be cross-referenced here in Python elftools to confirm that they are correct: https://github.com/eliben/pyelftools/blob/0c3283b3c872a0424bf4017a95ecee14aa6f17b8/elftools/dwarf/enums.py