+
Skip to content

Fix clippy warnings #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Fix clippy warnings #762

merged 1 commit into from
May 8, 2025

Conversation

DanielT
Copy link
Contributor

@DanielT DanielT commented May 7, 2025

  • lifetimes could be omitted or written as '_ in several cases
  • x.len() >= 1 was changed to !x.is_empty()

@philipc
Copy link
Collaborator

philipc commented May 8, 2025

The is_empty() change is fine, but I disagree with the lifetimes and prefer to add a clippy attribute to allow it instead.

@DanielT
Copy link
Contributor Author

DanielT commented May 8, 2025

Ok, no problem.
Is this a lint you never care about, in which case I would disable it in lib.rs for the whole crate.
Alternatively, I could annotate the individual lines with #[allow(clippy::needless_lifetimes)]

@philipc
Copy link
Collaborator

philipc commented May 8, 2025

Disable it in lib.rs please.

@DanielT
Fix clippy warnings
d5a831a 
- x.len() >= 1 was changed to !x.is_empty()
- the lint clippy::needless_lifetimes was disabled for the crate and for the examples
@philipc philipc merged commit 01edcb7 into gimli-rs:master May 8, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielT @philipc
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载