Remove #[non_exhaustive] from read::CallFrameInstruction #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
bjorn3
reviewed
May 29, 2025
Using #[non_exhaustive] disallows users of the library from exhaustively matching the enum. This is nice for semver, but terrible for library users who are now in the awkward position of having to remember to update their exhaustive match when updating gimli. This is less than ideal. I would know, as I now have to deal with it.
philipc
approved these changes
Jun 1, 2025
There was a problem hiding this comment.
Thanks!
Yes, this is fine. There are many other similar enums for which this crate doesn't have this attribute, so it doesn't make sense to single this out (and I would be fine with RegisterRule and write::CallFrameInstruction if someone wanted it).
There are also a few other enums where do we have non_exhaustive but I think those ones make sense to have.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
#[non_exhaustive]disallows users of the library from exhaustively matching the enum. This is nice for semver, but terrible for library users who are now in the awkward position of having to remember to update their exhaustive match when updating gimli.This is less than ideal. I would know, as I now have to deal with it.
PS:
RegisterRuleis also highly suspect, but as it hasn't yet created problems (for me at least), so I'll leave it be for now.