add path to ndk on termux on arm64 for android 9+ #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it available to build app on android app - termux
|
if it not working you can close and write this own |
eliasnaur
reviewed
May 26, 2023
There was a problem hiding this comment.
What about Termux on Android on x86_64 (emulator) or other GOARCHs? Your change only handles GOARCH arm64.
Also, I suggest changing the commit message to:
gogio: add support for Termux
Termux reports "android" for GOOS, but should be treated the same as "linux".
207e6f8 to
01ffdf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it available to build app on android app - termux
again