Add shellcheck for scripts, add dependency injection #182

kienstra · 2022-09-05T21:05:04Z

Changes

Add shellcheck for script linting. Most Bash is now in script/, so this can run shellcheck on it. This should help with Linux compatibility, as this helped to correct several Bash issues.
Add dependency injection. This allows using shellcheck, as it allows us to use a Jest test setup. I couldn't figure out how to do this will Mocha, the default VSC extension setup.

Mainly resolve in favor of this branch: add/shellcheck-and-dependency-injection

…e for the whole class

kienstra · 2022-09-14T00:17:44Z

.vscodeignore

@@ -1,5 +1,4 @@
 .vscode/**
-.vscode-test/**


This was where the compiled test files were before.

But now, we don't have to compile the TypeScript before running unit tests.

We'll just run jest.

kienstra added 30 commits August 27, 2022 23:23

Move some Bash scripts to src/scripts/ and run shellcheck for them

5c98271

Fix the shellcheck errors in get_picard_container()

fbffa9c

Strip the #from the scripts

9ebb13a

Add the index.ts file I forgot to stage

ed55f48

Fix shellcheck errors in addEnvVars

f52c1f0

Split the bash for docker exec into a script

2e88997

See if changing content to any helps

a5476bc

Attempt to get tests to pass with importing envVars.sh

6324808

Revert changes to package.json and package-lock.json

f81bc59

Add a baseUrl to tsconfig.json and update import statements

d5041c6

Fix imports in classes and util functions

d4f28d4

Fix linting errors

c28930b

Move subdirecdtories of src/utils/ into src/

4a39ec8

Switch to Jest for testing, move a single test to src/cache/test/

c65d5ef

Remove @vscode/test-electron

d8af63a

Attempt at Inversify, thought it's not working

8083a36

Use inversify for dependency injection, which is working right now

c739304

Add shellcheck for linting .sh files

e2c9fb1

Move test for getFinalTerminalName() into terminal/test

ed363bd

Merge in develop, resolve conflicts

fe4c2c2

Mainly resolve in favor of this branch: add/shellcheck-and-dependency-injection

Fix linting errors by removing any types

a657bf3

Make npm test pass by fixing the return types

5f978f5

Make tests pass again

2d0d0f9

Stage EnvPath, which I forgot to stage

4674bb6

mv types.ts to Types.ts

348c8f6

Add a test for the isMac() method, though should probably go in a fil…

29ee77c

…e for the whole class

Move getLogFilePath.spec.ts to log/test/

878d7ba

Move getDebuggingTerminalName.test.ts to terminal/

c84e0c5

Move getTerminalName.test.ts to terminal/

36707af

Move getFinalTerminalName.test.ts to terminal/

7734d20

kienstra added 12 commits September 11, 2022 23:45

Create a main extension file to activate and deactivate

8a8d2d0

Add more comamnds to Registrar

063e652

Change the description of the LocalCi test

3c1e352

Move the gateways to a gateway/ directory

1d6506f

Remove webview from src/

a7add97

Move commands/ to command/

f51e2ec

Move scripts/ to script/

c740486

Fix the bash syntax that didn't get the container

f2df33b

Strip the shellcheck command

0e1f9c0

Change vscode import to a type import when that's possible

eedb7f1

Remove sinon from the repo

ee8d7a9

Alphabetize the dependencies in import statements

8260d09

kienstra commented Sep 14, 2022

View reviewed changes

kienstra added 9 commits September 13, 2022 19:33

Use the helper test function

af73bf5

Convert applyPipelineParameters() to a class

fa62294

Move logic to clean up images to script so this can lint it

ea4d074

Move the Bash syntax to commit the container into a script

2ce7ea7

Remove duplicate test

4a292a2

Use Object.entries() instead of Object.keys()

5b4f71a

Fix linting errors in LoggingProcessGateway

83719cd

Will revert: inject the logging gateway

d33a31f

Remove the conditional for assigning imageIdToExclude

c5179fa

kienstra changed the title ~~Add shellcheck for script linting, and dependency injection~~ Add shellcheck for script linting and dependency injection Sep 18, 2022

kienstra changed the title ~~Add shellcheck for script linting and dependency injection~~ Add shellcheck for scripts, add dependency injection Sep 18, 2022

kienstra marked this pull request as ready for review September 18, 2022 17:47

kienstra added 3 commits September 18, 2022 13:04

Stop using the LoggingChildProcessGateway

942a845

Bump the Node version in the test job

c0bf6ba

Remove the last digit in the docker image tag

8944aac

kienstra merged commit 05a0c80 into develop Sep 18, 2022

kienstra deleted the add/shellcheck-and-dependency-injection branch September 18, 2022 18:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add shellcheck for scripts, add dependency injection #182

Add shellcheck for scripts, add dependency injection #182

Uh oh!

kienstra commented Sep 5, 2022 •

edited

Loading

Uh oh!

kienstra Sep 14, 2022

Uh oh!

Uh oh!

Add shellcheck for scripts, add dependency injection #182

Add shellcheck for scripts, add dependency injection #182

Uh oh!

Conversation

kienstra commented Sep 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

kienstra Sep 14, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kienstra commented Sep 5, 2022 •

edited

Loading