+
Skip to content

Add shellcheck for scripts, add dependency injection #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 89 commits into from
Sep 18, 2022
Merged

Add shellcheck for scripts, add dependency injection #182

merged 89 commits into from
Sep 18, 2022

Conversation

kienstra
Copy link
Member

@kienstra kienstra commented Sep 5, 2022 •
edited
Loading

Changes

  • Add shellcheck for script linting. Most Bash is now in script/, so this can run shellcheck on it. This should help with Linux compatibility, as this helped to correct several Bash issues.
  • Add dependency injection. This allows using shellcheck, as it allows us to use a Jest test setup. I couldn't figure out how to do this will Mocha, the default VSC extension setup.

kienstra added 30 commits August 27, 2022 23:23
@kienstra
Move some Bash scripts to src/scripts/ and run shellcheck for them
5c98271
@kienstra
Fix the shellcheck errors in get_picard_container()
fbffa9c
@kienstra
Strip the #from the scripts
9ebb13a
@kienstra
Add the index.ts file I forgot to stage
ed55f48
@kienstra
Fix shellcheck errors in addEnvVars
f52c1f0
@kienstra
Split the bash for docker exec into a script
2e88997
@kienstra
See if changing content to any helps
a5476bc
@kienstra
Attempt to get tests to pass with importing envVars.sh
6324808
@kienstra
Revert changes to package.json and package-lock.json
f81bc59
@kienstra
Add a baseUrl to tsconfig.json and update import statements
d5041c6
@kienstra
Fix imports in classes and util functions
d4f28d4
@kienstra
Fix linting errors
c28930b
@kienstra
Move subdirecdtories of src/utils/ into src/
4a39ec8
@kienstra
Switch to Jest for testing, move a single test to src/cache/test/
c65d5ef
@kienstra
Remove @vscode/test-electron
d8af63a
@kienstra
Attempt at Inversify, thought it's not working
8083a36
@kienstra
Use inversify for dependency injection, which is working right now
c739304
@kienstra
Add shellcheck for linting .sh files
e2c9fb1
@kienstra
Move test for getFinalTerminalName() into terminal/test
ed363bd
@kienstra
Merge in develop, resolve conflicts
fe4c2c2 
Mainly resolve in favor of
this branch:
add/shellcheck-and-dependency-injection
@kienstra
Fix linting errors by removing any types
a657bf3
@kienstra
Make npm test pass by fixing the return types
5f978f5
@kienstra
Make tests pass again
2d0d0f9
@kienstra
Stage EnvPath, which I forgot to stage
4674bb6
@kienstra
mv types.ts to Types.ts
348c8f6
@kienstra
Add a test for the isMac() method, though should probably go in a fil…
29ee77c 
…e for the whole class
@kienstra
Move getLogFilePath.spec.ts to log/test/
878d7ba
@kienstra
Move getDebuggingTerminalName.test.ts to terminal/
c84e0c5
@kienstra
Move getTerminalName.test.ts to terminal/
36707af
@kienstra
Move getFinalTerminalName.test.ts to terminal/
7734d20
kienstra
kienstra commented Sep 14, 2022
View reviewed changes
.vscodeignore
@@ -1,5 +1,4 @@
.vscode/**
.vscode-test/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was where the compiled test files were before.

But now, we don't have to compile the TypeScript before running unit tests.

We'll just run jest.

@kienstra kienstra changed the title Add shellcheck for script linting, and dependency injection Add shellcheck for script linting and dependency injection Sep 18, 2022
@kienstra kienstra changed the title Add shellcheck for script linting and dependency injection Add shellcheck for scripts, add dependency injection Sep 18, 2022
@kienstra kienstra marked this pull request as ready for review September 18, 2022 17:47
@kienstra kienstra merged commit 05a0c80 into develop Sep 18, 2022
@kienstra kienstra deleted the add/shellcheck-and-dependency-injection branch September 18, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kienstra
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载