getlocalci · kienstra · Apr 23, 2022 · Apr 23, 2022 · Apr 23, 2022 · Apr 23, 2022
diff --git a/src/classes/JobProvider.ts b/src/classes/JobProvider.ts
@@ -41,15 +41,15 @@ export default class JobProvider
   readonly onDidChangeTreeData: vscode.Event<Job | undefined> =
     this._onDidChangeTreeData.event;
   private jobs: string[] = [];
-  private jobErrorType: JobError | undefined;
-  private jobErrorMessage: string | undefined;
-  private runningJob: string | undefined;
-  private jobDependencies: Map<string, string[] | null> | undefined;
+  private jobErrorType?: JobError;
+  private jobErrorMessage?: string;
+  private runningJob?: string;
   private logs: Record<string, string[]> = {};
 
   constructor(
     private readonly context: vscode.ExtensionContext,
-    private readonly reporter: TelemetryReporter
+    private readonly reporter: TelemetryReporter,
+    private jobDependencies?: Map<string, string[] | null>
   ) {}
 
   async init() {
@@ -162,7 +162,9 @@ export default class JobProvider
     return treeItem;
   }
 
-  getChildren(parentElement: Job | Log): vscode.TreeItem[] {
+  getChildren(
+    parentElement?: Job | Log
+  ): Array<Job | Log | Command | Warning | vscode.TreeItem> {
     if (!parentElement) {
       return this.jobs.length
         ? this.getJobTreeItems(
@@ -217,7 +219,7 @@ export default class JobProvider
     );
   }
 
-  getErrorTreeItems(): vscode.TreeItem[] {
+  getErrorTreeItems(): Array<vscode.TreeItem | Command | Warning> {
     const errorMessage = this.getJobErrorMessage();
 
     switch (this.jobErrorType) {

diff --git a/src/test/suite/classes/Job.test.ts b/src/test/suite/classes/Job.test.ts
@@ -0,0 +1,39 @@
+import * as assert from 'assert';
+import * as vscode from 'vscode';
+import Job from '../../../classes/Job';
+
+suite('Job', () => {
+  test('No element passed', () => {
+    const jobName = 'this-is-your-job';
+    assert.strictEqual(jobName, new Job(jobName, false, false).getJobName());
+  });
+
+  test('Is running', () => {
+    assert.strictEqual(
+      undefined,
+      new Job('example-job', false, false).contextValue
+    );
+    assert.strictEqual(
+      'isRunning',
+      new Job('example-job', true, false).contextValue
+    );
+  });
+
+  test('Is success', () => {
+    const job = new Job('example', false, false);
+    job.setIsSuccess();
+    assert.strictEqual('✅', job.description);
+
+    job.setIsFailure();
+    assert.strictEqual('❌', job.description);
+  });
+
+  test('Is expanded', () => {
+    const job = new Job('example', false, false);
+    job.setExpanded();
+    assert.strictEqual(
+      vscode.TreeItemCollapsibleState.Expanded,
+      job.collapsibleState
+    );
+  });
+});
diff --git a/src/test/suite/classes/JobProvider.test.ts b/src/test/suite/classes/JobProvider.test.ts
@@ -0,0 +1,41 @@
+import * as assert from 'assert';
+import * as vscode from 'vscode';
+import { Substitute } from '@fluffy-spoon/substitute';
+import TelemetryReporter from '@vscode/extension-telemetry';
+import JobProvider from '../../../classes/JobProvider';
+import Job from '../../../classes/Job';
+
+function getStubs(): [vscode.ExtensionContext, TelemetryReporter] {
+  return [
+    Substitute.for<vscode.ExtensionContext>(),
+    Substitute.for<TelemetryReporter>(),
+  ];
+}
+
+suite('JobProvider', () => {
+  test('No element passed', () => {
+    assert.deepStrictEqual([], new JobProvider(...getStubs()).getChildren());
+  });
+
+  test('No child', () => {
+    assert.deepStrictEqual(
+      [],
+      new JobProvider(...getStubs()).getChildren(new Job('foo', false, false))
+    );
+  });
+
+  test('Two children', () => {
+    const allJobs = new Map();
+    allJobs.set('foo', []);
+    allJobs.set('baz', ['foo']);
+    allJobs.set('example', ['foo']);
+
+    const jobProvider = new JobProvider(...getStubs(), allJobs);
+
+    const children = jobProvider.getChildren(new Job('foo', false, false));
+    assert.strictEqual(2, children.length);
+
+    assert.strictEqual('baz', (children[0] as Job)?.getJobName());
+    assert.strictEqual('example', (children[1] as Job)?.getJobName());
+  });
+});