+
Skip to content

Use Kernel.ceil/1 instead of Float.ceil/1 + Kernel.trunc/1 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2019
Merged

Use Kernel.ceil/1 instead of Float.ceil/1 + Kernel.trunc/1 #1

merged 2 commits into from
Jun 24, 2019

Conversation

preciz
Copy link
Contributor

@preciz preciz commented Jun 23, 2019

Just a small edit to make code more terse.

@gyson
Copy link
Owner

gyson commented Jun 23, 2019

👍

Kernel.ceil/1 is only available since Elixir 1.8.0, we would need to update Elixir version requirement here as well.

@preciz
Bump Elixir version required to 1.8
1401af4 
`Kernel.ceil/1` is available only since 1.8.
@preciz
Copy link
Contributor Author

preciz commented Jun 23, 2019 •
edited
Loading

I did a quick glance over Kernel.ceil/1 in the source but haven't noticed, thanks, maybe then merge later.

@gyson
Copy link
Owner

gyson commented Jun 24, 2019

Nice! I will merge this into master first. May create a new release later (probably sometime after Elixir 1.9 official available).

@gyson gyson merged commit 1ec2aec into gyson:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preciz @gyson
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载