Persist state of Apply circular mask square crop checkbox in localStorage #4541
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twrichards
approved these changes
Oct 10, 2025
Co-authored-by: Tom Richards <tom.richards@guardian.co.uk>
Co-authored-by: Tom Richards <tom.richards@guardian.co.uk>
Nah, I was the inflatable one in this relationship (thanks for looking!): |
andrew-nowak
approved these changes
Oct 13, 2025
|
Seen on auth, usage, image-loader, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @paperboyo 8 minutes and 45 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored with copilot.
What does this change?
We provide an option to apply a circular mask (only for 1:1 square crops) to easier visualise potential circular framing by platforms. Because not all crops will be presented as circles, the default value of that is off and we don’t want to change that. But some users who mostly crop for these contexts report having to check this checkbox repeatedly.
This change persists the state of this checkbox in browser’s localStorage.
How should a reviewer test this change?
Go to crop, choose
Square (1:1)option. Observe that default Apply circular mask is OFF. Switch it ON/OFF reloading browser to check if it’s now persisted.How can success be measured?
Users don’t need to click something multiple times a day.
Who should look at this?
@guardian/newsroom-resilience
Tested? Documented?