WIP: Add support for art::GetOsThreadStat to ThreadCountCloaker #1184
+83
−31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
zygote64: Failed to reach single-threaded state
#1133The issue is similar to #500, where zygote is waiting for a single thread to continue, otherwise it crashes.
For a while this has been changed to use
art::GetOsThreadStat
, so the old fix no longer works.See android source code for reference:
Not ready to be merged
While this does correctly cloak the same as it used to, processes are still being sigkilled. Zygote no longer crashes however.
It might be unrelated to this pull request but it would be nice to have someone look over it.