Pass BASE table through subsetter by default #3949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but black is angry, can you fix? i'll merge it afterwards |
|
tests also fail with |
RickyDaMa
commented
Sep 29, 2025
| _drop_tables_default += ["Feat", "Glat", "Gloc", "Silf", "Sill"] # Graphite | ||
| _no_subset_tables_default = [ | ||
| "avar", | ||
| "BASE", |
There was a problem hiding this comment.
General thought: we may want to implement something better than this in the future, because for example if a user is subsetting out scripts, it could be useful to remove no longer relevant BASE min/max records etc.
For now though I guess it's fine to keep the whole table around, since it's not going to do any harm
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have push access to the repo, but I've rebased #1866 without conflicts so hopefully we can get this merged 🙏