[feaLib] Don't try to combine ligature & multisub rules #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
reviewed
Jun 26, 2025
rsheeter
reviewed
Jun 26, 2025
rsheeter
approved these changes
Jun 26, 2025
6b33660 to
6191bf6
Compare
khaledhosny
reviewed
Jul 1, 2025
I'm not sure that this patch is the correct solution to this problem, but it is _a_ solution. Specifically the problem is that the AnySubstBuilder can generate multiple lookups, but when this happens those extra lookups do not get added to the appropriate feature. My solution here is to force a new lookup whenever we see that the AnySubstBuilder would otherwise contain mixed multiple/ligature sub rules, which cannot be combined anyway. Open to alternatives, but this does fix the issue.
6191bf6 to
c100879
Compare
khaledhosny
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that this patch is the correct solution to this problem, but it is a solution.
Specifically the problem is that the AnySubstBuilder can generate multiple lookups, but when this happens those extra lookups do not get added to the appropriate feature. My solution here is to force a new lookup whenever we see that the AnySubstBuilder would otherwise contain mixed multiple/ligature sub rules, which cannot be combined anyway.
Open to alternatives, but this does fix the issue.