fix: avoid conflict with freezegun #3836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original implementation meant that self is passed to default_timer. When freezegun overrides this with a function that doesn't take an argument, it casues a runtime error. By setting the _time value in the init method, self isn't passed automatically as the first argument
|
Here's a simple demonstration of the underlying issue def test_fn():
return "bar"
class TestA:
_fn = test_fn
def __init__(self):
self.foo = self._fn()
class TestB:
def __init__(self):
self._fn = test_fn
self.foo = self._fn()
try:
print("TestA result:", TestA().foo)
except Exception as e:
print("Exception from TestA:", e)
try:
print("TestB result:", TestB().foo)
except Exception as e:
print("Exception from TestB:", e)This script will output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation meant that self is passed to default_timer. When freezegun overrides this with a function that doesn't take an argument, it causes a runtime error.
By setting the _time value in the init method, self isn't passed automatically as the first argument
Although I found this issue using freezegun alongside fonttools, it affects anything that overrides time.perf_counter