Type hints #3826
Type hints #3826
Conversation
| @@ -40,7 +42,7 @@ def __repr__(self): | |||
| return "<'%s' table at %x>" % (self.tableTag, id(self)) | |||
|
|
|||
| def __eq__(self, other): | |||
| if type(self) != type(other): | |||
| if not isinstance(self, type(other)): | |||
There was a problem hiding this comment.
This is unrelated to type hints and changes the meaning of the code. The current code is written as intended: only compare when the types match exactly.
There was a problem hiding this comment.
You are right. I tried to avoid changes like this. I’ll remove it.
There was a problem hiding this comment.
flake complains about the !=. Can this changed to is not?
| @@ -691,6 +691,8 @@ def write(self, writer, font, tableDict, value, repeatIndex=None): | |||
| assert writer.items[lengthIndex] == b"\xde\xad\xbe\xef"[: conv.staticSize] | |||
| writer.items[lengthIndex] = lengthWriter.getAllData() | |||
|
|
|||
| def __repr__(self): | |||
There was a problem hiding this comment.
I recomment to make a separate PR for changes other than type annotations.
|
I fixed a few flake issues I missed. But tox is not happy at all when I run it locally. Is there anything I can do or can I ignore issues in files I didn’t touch? I have fixes some easy ones. But that is probably another PR? |
|
I think you need to And you should format the code with |
Add some type hints.