[subset] close unicodes over bidi mirror variants. #3801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching a change to harfbuzz, for context: harfbuzz/harfbuzz#5282 and harfbuzz/harfbuzz#5281
behdad
reviewed
Apr 11, 2025
33ec142 to
46bf388
Compare
46bf388 to
d6060fa
Compare
|
LGTM. Let's see if Cosimo has any input. |
behdad
reviewed
Apr 14, 2025
khaledhosny
approved these changes
Apr 15, 2025
|
thanks! The only suggestion I'd make is to have https://github.com/fonttools/fonttools/blob/main/MetaTools/buildUCD.py script also generate the new Mirrored.py (as opposed to running that manual grep+sed+awk command), like we do for Scripts and similar UCD related data files. I'll file an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching a change to harfbuzz, for context: harfbuzz/harfbuzz#5282 and harfbuzz/harfbuzz#5281
Draft as it still needs tests and we need to sort out the dep on python-bidi.