[feaLib] Remove duplicates from class pair pos classes #3804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Apr 23, 2025
| @@ -1471,7 +1471,9 @@ def add_class_pair_pos(self, location, glyphclass1, value1, glyphclass2, value2) | |||
| lookup = self.get_lookup_(location, PairPosBuilder) | |||
| v1 = self.makeOpenTypeValueRecord(location, value1, pairPosContext=True) | |||
| v2 = self.makeOpenTypeValueRecord(location, value2, pairPosContext=True) | |||
| lookup.addClassPair(location, glyphclass1, v1, glyphclass2, v2) | |||
| cls1 = tuple(sorted(set(glyphclass1))) | |||
There was a problem hiding this comment.
these glyphclass1/glyphclass2 are they supposed to be of type set or tuple? The docstring of addClassPair method says "set"
There was a problem hiding this comment.
If I use set, I get an error down the line that it it is unhashable type. They are used as a dict key.
anthrotype
approved these changes
Apr 23, 2025
AFDKO’s makeotf removes the duplicates and produces the following
message:
NOTE: [line 3 char 29] Removing duplicate glyph <A>
NOTE: [line 3 char 29] Removing duplicate glyph <A>
While feaLib fails with:
Traceback (most recent call last):
File "/fonttools/Lib/fontTools/feaLib/builder.py", line 875, in buildLookups_
otLookups.append(l.build())
^^^^^^^^^
File "/fonttools/Lib/fontTools/otlLib/builder.py", line 1460, in build
builder.addPair(glyphclass1, value1, glyphclass2, value2)
File "/fonttools/Lib/fontTools/otlLib/builder.py", line 1340, in addPair
self.classDef1_.add(gc1)
File "/fonttools/Lib/fontTools/otlLib/builder.py", line 2656, in add
raise OpenTypeLibError(
fontTools.otlLib.error.OpenTypeLibError: Glyph A is already present in class.
c2486c1 to
95b5747
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFDKO’s makeotf removes the duplicates and produces the following message:
While feaLib fails with: