[ttLib] Ignore component bounds if empty #3799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, if the bounds of a component have zero area, do not consider it when computing the bounds of the parent. This handles the case of a composite glyph where all the components are themselves empty, which if it sounds weird you're probably new around here.
|
@qxliu76 Is this something HB needs fixing as well? |
|
do we have a testcase that shows the problem? |
|
I'd like a test case so I can take a look:) |
|
good catch! thanks |
|
@qxliu76 @behdad I have just distilled a test font from @cmyr's unit test, you'll find it attached below: RecalcBoundsEmptyComponentsNested-Regular.ttf.zip If you rountrip the font through ttx (with this PR merged on main), you'll notice that the bounds of glyph "bar" have been updated (i.e. inheriting the bounds of its non-empty component, ignoring the empty one) ttx -q -o - "/Users/clupo/oss/fonttools/master_ttf/RecalcBoundsEmptyComponentsNested-Regular.ttf" 2>/dev/null
ttx -q -o - "/Users/clupo/oss/fonttools/master_ttf/RecalcBoundsEmptyComponentsNested-Regular#1.ttf" 2>/dev/null
--- /dev/fd/63 2025-04-22 15:01:11
+++ /dev/fd/62 2025-04-22 15:01:11
@@ -14,12 +14,12 @@
<!-- Most of this table will be recalculated by the compiler -->
<tableVersion value="1.0"/>
<fontRevision value="1.0"/>
- <checkSumAdjustment value="0xf5e5411a"/>
+ <checkSumAdjustment value="0xf5df4094"/>
<magicNumber value="0x5f0f3cf5"/>
- <flags value="00000000 00000011"/>
+ <flags value="00000000 00000001"/>
<unitsPerEm value="1000"/>
<created value="Tue Apr 22 13:50:52 2025"/>
- <modified value="Tue Apr 22 13:59:53 2025"/>
+ <modified value="Tue Apr 22 14:00:55 2025"/>
<xMin value="0"/>
<yMin value="-200"/>
<xMax value="450"/>
@@ -166,7 +166,7 @@
<instructions/>
</TTGlyph>
- <TTGlyph name="bar" xMin="0" yMin="0" xMax="10" yMax="10">
+ <TTGlyph name="bar" xMin="5" yMin="5" xMax="10" yMax="10">
<component glyphName="foofoo" x="0" y="0" flags="0x4"/>
<component glyphName="doo" x="0" y="0" flags="0x4"/>
</TTGlyph> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if the bounds of a component have zero area, do not consider it when computing the bounds of the parent.
This handles the case of a composite glyph where all the components are themselves empty, which if it sounds weird you're probably new around here.