+
Skip to content

Conversation

TomDonoghue
Copy link
Member

Responds to #218

Main updates:

  • adds settings to a saved out FOOOFGroup report
  • adds the option to choose whether settings are saved for saving out both FOOOF and FOOOFGroup reports
  • tweaks some sizing to make the reports work / look good
  • adds the option to pass in explicit figure sizes for model plots

Note: for review, the code changes here are fairly simple - but it would be useful to check that when running the report generation code locally, that the sizing and layout looks alright!

@TomDonoghue TomDonoghue requested a review from ryanhammonds June 29, 2023 19:12
@TomDonoghue TomDonoghue added the 1.1 Targetted for a fooof 1.1 release. label Jun 29, 2023
Copy link
Contributor

@ryanhammonds ryanhammonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reports look good when I use the new option!

@TomDonoghue TomDonoghue merged commit 208fc09 into main Jun 29, 2023
@TomDonoghue TomDonoghue deleted the grep branch June 29, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.1 Targetted for a fooof 1.1 release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载