[BUG] - Fix embedded lists for ap_fit guess #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short version: the fixed line ended up with an extra layer of embedded lists which led to downstream problems.
The longer version (why it's a problem):
In practice, we never bound the aperiodic fits, but in theory one could, by update
_ap_bounds. However - if one tried to do this, then the fitting actually gets kicked to a different approach, which then checks that the guess parameters are 1d. This would then fail, because the embedded list made them 2d. This PR fixes that.Note that this change doesn't change anything that happens in standard usage - but will make it possible to add
_ap_bounds, in which case what happens in the fitting is slightly different.