Add feature flag scaffolding to support experiments restricted to a specific Flutter channel #9440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevmoo
reviewed
Sep 18, 2025
bkonyi
reviewed
Sep 18, 2025
bkonyi
approved these changes
Sep 19, 2025
| /// | ||
| /// https://github.com/flutter/devtools/issues/7854 | ||
| static bool inspectorV2 = true; | ||
| static final inspectorV2 = BooleanFeatureFlag( |
There was a problem hiding this comment.
Same here and below. If we don't need these feature flags anymore, we may as well remove them.
bkonyi
reviewed
Sep 19, 2025
| enabled: true, | ||
| ); | ||
|
|
||
| /// Stores a map of all the feature flags for debugging purposes. |
There was a problem hiding this comment.
This isn't a map anymore :)
srawlins
approved these changes
Sep 19, 2025
packages/devtools_app/test/shared/primitives/feature_flags_test.dart
Outdated
Show resolved
Hide resolved
packages/devtools_app/test/shared/primitives/feature_flags_test.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #9438
Previously all feature flags in DevTools could only be controlled by a boolean. This PR allows us to specify a Flutter channel to enable a feature for (e.g.
betawill enable the experiment if a user is on thebetachannel or adevbranch of Flutter). See #9439 for why this is using Flutter instead of Dart channels.FYI @kevmoo @mdebbar @natebiggs - This will allow us to enable dart2wasm compilation for everyone on Flutter beta now (which will go out on Oct 15th) without having to wait for the next beta after Flutter 3.38 (which will go out on November 12th).