Remove scaleByFontFactor method and usages
#9304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkonyi
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8243
Previously, the IDEs passed their current font size to embedded DevTools via a query param. DevTools would then try to scale all UI elements by the ratio of the IDE font size to the default font size.
However, this resulted in strange UI element sizing - some elements were scaled too large, and others were not being scaled at all.
Instead, the IDEs now handle scaling the embedded DevTools panel themselves, and no longer pass in the font size as a query parameter to DevTools (see VS Code change, IntelliJ change).
Therefore this PR:
scaleByFontFactormethodscaleByFontFactorFiled #9305 for the goldens change - I think they are a side effect of how Flutter handles asset loading during golden testing, and not an indication that anything has changed here.