Upgrade to CKAN 2.11 #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ntwalibas - should we add a release tag to the previous version so that projects can continue to easily use the version from before the 2.11 migration |
jonathansberry
requested changes
Dec 5, 2024
| import ckan.views.resource as resource | ||
| import ckan.plugins.toolkit as tk | ||
| import ckan.views.api as api | ||
| from ckan.common import g |
There was a problem hiding this comment.
Can get this from the toolkit: toolkit.g
Comment on lines
+50
to
+51
| context = {"model": model, "session": model.Session, "user": user} | ||
| package = toolkit.get_action("package_show")(context, {"id": path_id}) |
There was a problem hiding this comment.
It is my understanding that toolkit.get_action automatically adds the model and session and user to the context. I believe this also means you don't need to import the model.
Suggested change
| context = {"model": model, "session": model.Session, "user": user} | |
| package = toolkit.get_action("package_show")(context, {"id": path_id}) | |
| package = toolkit.get_action("package_show")({}, {"id": path_id}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR performs a major refactoring and enhancement:
It remains to have the following properly implemented:
Testing
Tests to follow while functionality is being reviewed.
Documentation
The documentation needs to be improved so it is easier to install this extension in new projects.
Checklist