+
Skip to content

Conversation

ChasNelson1990
Copy link
Member

@ChasNelson1990 ChasNelson1990 commented Jan 31, 2025

Description

I tried to deploy to AFRO staging and I got a KeyError saying that the visits object had no recent key.

I do not understand this plugin well enough to know why this scenario would occur; however, as I needed to deploy I have introduced this 🔥 hot fix 🔥

Important: this may not be the correct fix so I have assigned @ntwalibas so that he can properly investigate this

relates fjelltopp/ckanext-who-afro#89
relates fjelltopp/who-afro-ckan#

Dependency Changes

See who-afro-ckan and specifically fjelltopp/who-afro-ckan#

Testing

Local dev environment and staging deployed through Azure Pipelines now work.

Checklist

  • The GitHub ticket for this issue has been updated to "Ready to Review" or equivalent.
  • I have developed these changes in discussion with the appropriate project manager.
  • My code follows the general Fjelltopp documentation (see Confluence).
  • I have made corresponding changes to the Fjelltopp documentation (see Confluence).
  • I have rebased this branch with master.
  • New dependency changes have been committed.
  • I have added automated tests that prove my fix is effective or that my feature works.
  • New and existing tests pass locally with my changes.
  • My changes generate no new warnings.
  • I have performed a self-review of my own code.
  • I have assigned at least one reviewer.
  • I have assigned at least one label to this PR: "patch", "minor", "major".

Copy link
Collaborator

@ntwalibas ntwalibas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChasNelson1990 ChasNelson1990 merged commit 866eebe into master Jan 31, 2025
@ChasNelson1990 ChasNelson1990 deleted the fix-no-visits branch January 31, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载