+
Skip to content

Fix for issue-670: Changed var to const #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2019
Merged

Fix for issue-670: Changed var to const #687

merged 4 commits into from
Feb 5, 2019

Conversation

AlvinValdez
Copy link
Contributor

Updated code in filer/src/stats.js to use const instead of var.

@codecov-io
Copy link

codecov-io commented Jan 28, 2019 •
edited
Loading

Codecov Report

Merging #687 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #687   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files          16       16           
  Lines        1746     1746           
=======================================
  Hits         1514     1514           
  Misses        232      232
Impacted Files Coverage Δ
src/stats.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b47ee...22e9e9f. Read the comment docs.

@vincentfullstack
Copy link

You can add 'use strict' in the top of the file

@AlvinValdez AlvinValdez changed the title Changed var to const Fix for issue-670: Changed var to const Jan 30, 2019
SahibArora
SahibArora reviewed Jan 30, 2019
View reviewed changes
Copy link
Contributor

@SahibArora SahibArora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try using the steps provided > https://github.com/filerjs/filer/blob/develop/CONTRIBUTING.md#how-to-contribute
Must remove your error if you only changed the var to const/let in previous commits :)

humphd
humphd approved these changes Feb 5, 2019
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@humphd
Copy link
Contributor

humphd commented Feb 5, 2019

One tip: instead of Fix for issue-670 use Fixes #670 and GitHub will autoclose the issue when this gets merged. See https://help.github.com/articles/closing-issues-using-keywords/

@humphd humphd merged commit 0ec51a1 into filerjs:master Feb 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@humphd humphd humphd approved these changes

+1 more reviewer

@SahibArora SahibArora SahibArora left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AlvinValdez @codecov-io @vincentfullstack @humphd @SahibArora
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载