Fix problematic type signatures #1158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In class method context, `self` refers to the class itself, not the instance
We include `DataConverter` in `StructByReference`, and change `#native_type` method arity when overwriting it. This change adds optional `_type` argument that defaults to nil.
5b47769 to
dc5e49c
Compare
|
@larskanis Could you run CI again on this PR? @y9v repaired the issues identified in the previous run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes type signatures for
FFI::AutoPointer#initialize,FFI::StructByReference#native_type, andFFI::Struct#auto_ptr.Closes #1107.