+
Skip to content

Conversation

sdomi
Copy link
Contributor

@sdomi sdomi commented Oct 12, 2025

Fixes a use-after-free introduced in 3f4f035, where on successful style deduplication the loop would continue, and fail to dereference the style pointer on next iteration, leading to a segfault.

Of note, I can only reproduce this on musl, but the bug was equally present on glibc. AFAICT glibc is a bit more lax with clearing leftovers after using free(), so it went unnoticed.

@ThomasAdam ThomasAdam added the type:bug Something's broken! label Oct 13, 2025
@ThomasAdam ThomasAdam added this to the 1.1.4 milestone Oct 13, 2025
@ThomasAdam ThomasAdam self-assigned this Oct 13, 2025
@ThomasAdam ThomasAdam added this to FVWM3 Oct 13, 2025
@github-project-automation github-project-automation bot moved this to PRs in FVWM3 Oct 13, 2025
@ThomasAdam ThomasAdam merged commit cabd616 into fvwmorg:main Oct 13, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from PRs to Done in FVWM3 Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something's broken!

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载