Looks like this is caused by the abandoned method not checking if the order was refunded, and assuming any badge with a paidTotal of 0 and any effectiveLevel should be considered comped.

APIS/registration/models.py

Lines 490 to 496 in 8c664e1

    
           if self.paidTotal() > 0: 
        
               return Badge.PAID 
        
           level = self.effectiveLevel() 
        
           if level == Badge.UNPAID: 
        
               return Badge.UNPAID 
        
           if level: 
        
               return Badge.COMP

Looking at both the paidTotal and effectiveLevel methods, it seems like they only consider UNPAID orders as unpaid, and doesn't consider the order status at all.

APIS/registration/models.py

Lines 503 to 504 in 8c664e1

    
           if oi.order.billingType == Order.UNPAID: 
        
               return Badge.UNPAID

Could this check be updated to something that uses the order status?

if oi.order.billingType == Order.UNPAID or oi.order.status not in (Order.CAPTURED, Order.COMPLETED):
    return Badge.UNPAID

	if self.paidTotal() > 0:
	return Badge.PAID
	level = self.effectiveLevel()
	if level == Badge.UNPAID:
	return Badge.UNPAID
	if level:
	return Badge.COMP

Refunded orders show up as "Comp" status in onsite admin search #280

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions