Fixes sense issues in TextEdit when vertical alignment is used #7436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/7436-alignfix |
lucasmerlin
approved these changes
Aug 8, 2025
| }; | ||
|
|
||
| let mut offset_x = state.singleline_offset; | ||
| let mut offset_x = state.text_offset[0]; |
There was a problem hiding this comment.
Suggested change
| let mut offset_x = state.text_offset[0]; | |
| let mut offset_x = state.text_offset.x; |
A bit more idiomatic
lucasmerlin
reviewed
Aug 8, 2025
Comment on lines
52
to
53
| // Visual offset when editing singleline text bigger than the width. | ||
| #[cfg_attr(feature = "serde", serde(skip))] |
There was a problem hiding this comment.
Ah yeah it'd be nice if you could update the comment
emilk
reviewed
Aug 12, 2025
Comment on lines
655
to
656
| let align_offset_x = rect.left() - galley_pos.x; | ||
| let align_offset_y = rect.top() - galley_pos.y; |
There was a problem hiding this comment.
Suggested change
| let align_offset_x = rect.left() - galley_pos.x; | |
| let align_offset_y = rect.top() - galley_pos.y; | |
| let align_offset = rect.left_top() - galley_pos; |
emilk
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vertical_align#7433I'm running a rustup-less rust install on Windows, so I don't have
clippynorfmtand can't run the .sh script.It's very little code and I manually tested this, so hopefully that's ok...
Let me know if the comment in
state.rsneeds to be updated or thetext_offsetname isn't clear enough.