Prevent panic when copying text outside of a secure context #5326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
YgorSouza
commented
Oct 30, 2024
- Closes Copy (CTRL+C and ui.output_mut) crash if HTTP #5293
- I have followed the instructions in the PR template
|
Preview available at https://egui-pr-preview.github.io/pr/5326-fix-web-clipboard-panic |
rustbasic
reviewed
Oct 30, 2024
|
Thank you! Maybe we should also update the copy_text docs to mention that this might not work for wasm builds outside of secure contexts / when the app is deployed without https? |
emilk
approved these changes
Oct 30, 2024
I added it, although I don't know if this is the right place for that, since it doesn't really have anything to do with egui, it's just how wasm works. But I guess at least it is hard to miss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.