fix: abstract base classes should implement shared type interfaces #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be fastracked a bit? I can't upgrade to .32 without it, and that pulls in security fixes for versions of ws and decompress-zip. npm audit refers to them as "high" |
MarshallOfSound
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are appropriately documented(not applicable).Summarize your changes:
When I was researching #683, I found it odd that the abstract
Baseclasses didn't implement the interfaces that are in use in@electron-forge/corewhen executing the plugins. If this is some TypeScript pattern, let me know and I'll update the PR to just have the emptyinit()method.Fixes #683.