+
Skip to content

fix(maker-wix): correct path to distributable #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2018
Merged

fix(maker-wix): correct path to distributable #609

merged 2 commits into from
Nov 17, 2018

Conversation

liudonghua123
Copy link
Contributor

@liudonghua123 liudonghua123 commented Oct 25, 2018 •
edited by malept
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Fixes #608.

@MarshallOfSound
Copy link
Member

Good catch 🙇

@malept
Copy link
Member

malept commented Oct 25, 2018

Hmmm. Shouldn't the maker specs test that the output file paths returned exist?

@malept malept changed the title Update MakerWix.ts fix: path to wix maker distributable Oct 25, 2018
@MarshallOfSound
Copy link
Member

@malept In this case the tests were passing because the file returned from the maker msiFile did actually exist, it was just in a stupid place 😆 We might be able to add a path.relative test to ensure it isn't in a stupid place in the future

@malept malept mentioned this pull request Nov 8, 2018
Closed
5 tasks
@mako-taco
Copy link

Can we get this merged? The 2 failing test cases are also affecting my completely unrelated changes in #623, which makes me think they are also unrelated to these changes.

@malept
Copy link
Member

malept commented Nov 9, 2018

I'd like it if the test that was mentioned in the comments here were addressed before we merge, to avoid problems like this in the future.

@malept
Copy link
Member

malept commented Nov 15, 2018

I think I've written a regression test for this (2392832) but the tests are failing due to failures that are also in master.

@malept malept changed the title fix: path to wix maker distributable fix(maker-wix): path to wix maker distributable Nov 17, 2018
@malept malept changed the title fix(maker-wix): path to wix maker distributable fix(maker-wix): correct path to distributable Nov 17, 2018
@malept malept merged commit 50a4f06 into electron:master Nov 17, 2018
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
@ckerr
fix: accidental switch fall-through in remote-loader (#609)
ae3a6f1 
* fix: accidental switch fall-through in remote-loader

* chore: undo unnecessary change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liudonghua123 @MarshallOfSound @malept @mako-taco
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载