+
Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
The current paths for the 5.x branch.
I'm not sure if the windows paths are correct, please verify.

@ghost
Copy link
Author

ghost commented Jul 5, 2018

Uggh the windows newline. Lemme see if i can fix that.

Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@ghost
Copy link
Author

ghost commented Jul 5, 2018

I don't think they were using windows style newlines from the start, but shouldn't they have been?

Also, the shell script SHOULD have an EOF newline.

@MarshallOfSound MarshallOfSound merged commit f1b90b6 into electron:master Jul 5, 2018
dsanders11 pushed a commit that referenced this pull request Jan 14, 2023
Co-authored-by: Issac Gerges <gergesim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载