+
Skip to content

Conversation

malept
Copy link
Member

@malept malept commented May 13, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Like #509 but for 6.x.

ISSUES CLOSED: #508

@malept malept requested a review from MarshallOfSound May 13, 2018 06:23
@MarshallOfSound
Copy link
Member

tests broke 😢

@malept
Copy link
Member Author

malept commented May 13, 2018

Well, the start tests in master are busted for some reason...

@MarshallOfSound
Copy link
Member

Well, the start tests in master are busted for some reason...

Heh, will deal with on monday

@malept
Copy link
Member Author

malept commented May 18, 2018

Tests passed! 🎉

@MarshallOfSound MarshallOfSound merged commit ce36356 into master May 18, 2018
@MarshallOfSound MarshallOfSound deleted the disable-packager-all branch May 18, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载