+
Skip to content

ci: upload test artifacts #42925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 17, 2024
Merged

ci: upload test artifacts #42925

merged 10 commits into from
Jul 17, 2024

Conversation

samuelmaddock
Copy link
Member

@samuelmaddock samuelmaddock commented Jul 16, 2024 •
edited
Loading

Description of Change

Upload test artifacts from GH runners.

Currently the only place these are used are for failed screen capture tests.

electron/spec/lib/screen-helpers.ts

Lines 170 to 174 in 778d309

// Save the image as an artifact for better debugging
const artifactName = await createArtifactWithRandomId(
(id) => `color-mismatch-${id}.png`,
frame.toPNG()
);

I've updated this code to limit the output to 720p for cost saving purposes.

Checklist

Release Notes

Notes: none

@samuelmaddock samuelmaddock reopened this Jul 16, 2024
@samuelmaddock
Copy link
Member Author

samuelmaddock commented Jul 16, 2024 •
edited
Loading

Conveniently there was a screen capture test failure which uploaded artifacts. Seems like our screen capture tests need to clear all notifications and hide any windows.

The above might be fixed by the changes in #42320 which continuously capture frames until a timeout—if the issue resolves itself after a second or so.

color-mismatch-78c85d271f6c72785962b027

@samuelmaddock samuelmaddock added target/29-x-y PR should also be added to the "29-x-y" branch. target/30-x-y PR should also be added to the "30-x-y" branch. target/31-x-y PR should also be added to the "31-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. labels Jul 16, 2024
@samuelmaddock samuelmaddock requested a review from jkleinsc July 16, 2024 23:46
@VerteDinde VerteDinde merged commit c770974 into electron:main Jul 17, 2024
@release-clerk
Copy link

release-clerk bot commented Jul 17, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Jul 17, 2024

I was unable to backport this PR to "31-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/31-x-y PR should also be added to the "31-x-y" branch. label Jul 17, 2024
@trop
Copy link
Contributor

trop bot commented Jul 17, 2024

I was unable to backport this PR to "30-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot added needs-manual-bp/31-x-y and removed target/30-x-y PR should also be added to the "30-x-y" branch. labels Jul 17, 2024
@samuelmaddock samuelmaddock deleted the patch-2 branch July 17, 2024 13:02
@samuelmaddock
Copy link
Member Author

I'm removing the backports as the earlier branches won't have the screen capture test stability improvements made in #42320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@codebytere codebytere Awaiting requested review from codebytere

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
semver/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samuelmaddock @VerteDinde
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载