Upgraded dependencies and simplified venv #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded rules_python Upgraded rules_lint Upgraded rules_py Changed venv to use new 'data' attribute Added .bazelversion to ensure same version is used Added .bazelrc to ensure same behaviour as in other repos
|
Integration tests work. I hope with the workflow that is added this will then run into the CI for any future PR's Also manually checked that 'pyproject.toml' is been taking with into the virtualenv (due to the indirection via py_library being deleted). This is the case. |
nicu1989
reviewed
May 23, 2025
| srcs = ["@score_python_basics//:dummy_venv.py"], | ||
| data = ["@score_python_basics//:pyproject.toml"], | ||
| deps = all_requirements + reqs + [":config", "@rules_python//python/runfiles"] , | ||
| data = ["@score_python_basics//:pyproject.toml"] |
There was a problem hiding this comment.
We should start documenting line by line why that line is there....
| module( | ||
| name = "score_python_basics", | ||
| version = "0.3.1", | ||
| version = "0.3.2", |
There was a problem hiding this comment.
This updates packaging to a new major version. That's not a patch release. (After 0.x)
AlexanderLanin
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.