+
Skip to content

Conversation

lavrovvalera
Copy link
Contributor

@lavrovvalera lavrovvalera commented Aug 5, 2025

  • Added stakeholder requirements
  • Updates Feature requirements

Copy link

github-actions bot commented Aug 5, 2025

The created documentation from the pull request is available at: docu-html

Copy link
Contributor

@hth9fe hth9fe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall I guess in IDs and requirement names we should use the word "mockup" or "mocking" instead of "fake" and "faking"

I believe Time Synchronization has Security relevance, but we can discuss this..

:rationale: Enables the system to synchronize its internal clock with external time sources, ensuring the data aging across distributed ECUs.
:status: valid

The software platform shall provide time synchronization framework to synchronize its clock with external time sources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The software platform shall provide time synchronization framework to synchronize its clock with external time sources.
The software platform shall provide a time synchronization framework to synchronize its clock with external time sources.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

.. stkh_req:: Time Synchronization
:id: stkh_req__time__synchronization
:reqtype: Functional
:security: NO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what could happen if the time sychronization can be manipulated... Therefore I would expect that time sychronization is subject of necessary security measures...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For synchronization to external sources - definitely.
For in-vehicle,I would say - no

The software platform shall provide a method and interface to enable
debugging of the software on target and in vehicle.

.. stkh_req:: Fake implementation for application testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. stkh_req:: Fake implementation for application testing
.. stkh_req:: Mockup implementation for application testing

Let's use the more development like term "mockup" or "Mocking". At least in the requirement headline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Testability
^^^^^^^^^^^^

.. feat_req:: score::time fake APIs implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. feat_req:: score::time fake APIs implementation
.. feat_req:: score::time mockup APIs implementation

Let's use mockup instead of fake

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

^^^^^^^^^^^^

.. feat_req:: score::time fake APIs implementation
:id: feat_req__time__apis_faking
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:id: feat_req__time__apis_faking
:id: feat_req__time__apis_mocking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

:reqtype: Functional
:security: NO
:safety: QM
:satisfies: stkh_req__dev_experience__fake_public_apis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:satisfies: stkh_req__dev_experience__fake_public_apis
:satisfies: stkh_req__dev_experience__mockup_public_apis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

.. feat_req:: Time client PTP sync
:id: feat_req__time__trec_external_sync_ptp
:reqtype: Functional
:security: NO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:security: NO
:security: NO

already mentioned below. I guess security is relevant here

debugging of the software on target and in vehicle.

.. stkh_req:: Fake implementation for application testing
:id: stkh_req__dev_experience__fake_public_apis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:id: stkh_req__dev_experience__fake_public_apis
:id: stkh_req__dev_experience__mockup_public_apis

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

:status: valid

The software platform shall provide a time synchronization framework to synchronize its clock
with external to ECU, but internal to vehicle time sources.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
with external to ECU, but internal to vehicle time sources.
to Time Master within the vehicle

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for event timestamping and chronological events comparison.
:status: valid

The software platform shall provide an API to read the synchronized time from Local Time Slave.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The software platform shall provide an API to read the synchronized time from Local Time Slave.
The software platform shall provide an API to access the synchronized vehicle time.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


* for AVB nodes the maximum difference in the synchronized time between two AVB ports/ECUs while
both are in state SYNC, and could be 1 usec
* for non-AVB node the precision is released, comparing to AVB ones
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the upper limit: 200-500 usec

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

precision, based on the system setup.

Note:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the particular thresholds depends on the system setup

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamping, converting and so on) which take part in time communication, based on the system setup.
Note:

* for AVB nodes the threshold the threshold might be 100 nsec
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* for AVB nodes the threshold the threshold might be 100 nsec
* for AVB nodes the threshold might be 100 nsec

:rationale: Enables the system to compare high frequent events chronologically.
:status: valid

The software platform shall keep the threshold for all local clock adaptations (including
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The software platform shall make local clock adaptations (...) within the predefined time window

When it starts?
Does it make sense tomove it to the feature level?


The software platform shall provide the APIs to read the current monotonic clock from the system time provider.

Note: to which clock the monotonic clock is mapped, depends on the system design.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. synchronization to Time master with external to ECU (shall support)
  2. synchronization to external time base ECU (UTC) 8shall support)
  3. provide tha access to differnet timebases (or per timebase)

all the rest move to feature reqs.

@lavrovvalera lavrovvalera force-pushed the vala_time_feature_stkh_reqs branch from 4e4b026 to e415463 Compare August 11, 2025 09:31
@lavrovvalera lavrovvalera force-pushed the vala_time_feature_stkh_reqs branch from e415463 to 701b157 Compare August 11, 2025 11:36
@lavrovvalera lavrovvalera marked this pull request as ready for review August 11, 2025 11:39
@qor-lb qor-lb merged commit f03cc0d into eclipse-score:lb_time_feature_request Aug 11, 2025
6 checks passed
qor-lb pushed a commit that referenced this pull request Aug 11, 2025
* feature time: Add stakeholder requirements

* feature:time: Update stakeholder requirements

- Update requirements
- Fix review comments

* feature:time: Update stakeholder requirements

* feature:time: Update stakeholder requirements

* Fix review comments
qor-lb pushed a commit that referenced this pull request Sep 1, 2025
* feature time: Add stakeholder requirements

* feature:time: Update stakeholder requirements

- Update requirements
- Fix review comments

* feature:time: Update stakeholder requirements

* feature:time: Update stakeholder requirements

* Fix review comments
qor-lb pushed a commit that referenced this pull request Sep 1, 2025
* feature time: Add stakeholder requirements

* feature:time: Update stakeholder requirements

- Update requirements
- Fix review comments

* feature:time: Update stakeholder requirements

* feature:time: Update stakeholder requirements

* Fix review comments
masc2023 pushed a commit to esrlabs/score that referenced this pull request Oct 8, 2025
* feature time: Add stakeholder requirements

* feature:time: Update stakeholder requirements

- Update requirements
- Fix review comments

* feature:time: Update stakeholder requirements

* feature:time: Update stakeholder requirements

* Fix review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载