+
Skip to content

Conversation

aschemmel-tech
Copy link
Contributor

No description provided.

@aschemmel-tech aschemmel-tech marked this pull request as draft July 23, 2025 12:57
@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-establish-codeowners branch from a20f6b2 to cb4d74b Compare July 23, 2025 12:59
Copy link

The created documentation from the pull request is available at: docu-html

@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-establish-codeowners branch 2 times, most recently from 8deec57 to 7904bd3 Compare July 23, 2025 13:45
@FScholPer
Copy link
Contributor

Why do we not use the teams?

@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-establish-codeowners branch 4 times, most recently from a6d33e4 to 3b2829d Compare July 25, 2025 13:25
@aschemmel-tech
Copy link
Contributor Author

Why do we not use the teams?

To use "Teams" in the CODEOWNERS file, they must have write access to the repository. Currently this is only granted to @eclipse-score/automotive-score-committers. This must be intitiated via Eclipse Support. I am not sure they will do this, because in our current Teams are people without the committer status. So if we would grant these Teams write access this would somehow break the committer election process. I do not want to wait until this gets clarified.

@aschemmel-tech aschemmel-tech marked this pull request as ready for review July 25, 2025 13:33
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine from my side

Copy link
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some changes to consider, quality and security not fully setup, shall we consider now or later?

FScholPer
FScholPer previously approved these changes Aug 4, 2025
Copy link
Contributor

@FScholPer FScholPer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

antonkri
antonkri previously approved these changes Aug 4, 2025
# /integration_tests @eclipse-score/automotive-score-committers
# /tools @eclipse-score/infrastructure-tooling-community
# /docs/ @eclipse-score/community-process
/docs/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/docs/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech
/docs/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech
/docs/conf.py @AlexanderLanin @MaximilianSoerenPollak @dcalavrezo-qorix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fixed

/docs/contribute/ @eclipse-score/automotive-score-committers
# /docs/features/ @eclipse-score/automotive-score-technical-leads
/docs/features/ @antonkri @FScholPer @qor-lb @johannes-esr @markert-r
_assets/ @eclipse-score/automotive-score-committers
Copy link
Member

@AlexanderLanin AlexanderLanin Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means every committer can modify all assets regardless of the specific assignments made int this file so far. In this intentional?

E.g. every committer can modify images in features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now I think of it, maybe you are right, I will remove this.

@aschemmel-tech aschemmel-tech dismissed stale reviews from antonkri and FScholPer via 23e68e8 August 4, 2025 10:02
@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-establish-codeowners branch 2 times, most recently from 23e68e8 to cd625d5 Compare August 4, 2025 11:01
@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-establish-codeowners branch from cd625d5 to 7255fab Compare August 4, 2025 11:23
@aschemmel-tech aschemmel-tech merged commit 92f3bdc into main Aug 4, 2025
8 checks passed
@aschemmel-tech aschemmel-tech deleted the aschemmel-tech-establish-codeowners branch August 4, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载