-
Notifications
You must be signed in to change notification settings - Fork 60
Establish the CODEOWNER file for score repo #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a20f6b2
to
cb4d74b
Compare
The created documentation from the pull request is available at: docu-html |
8deec57
to
7904bd3
Compare
Why do we not use the teams? |
a6d33e4
to
3b2829d
Compare
To use "Teams" in the CODEOWNERS file, they must have write access to the repository. Currently this is only granted to @eclipse-score/automotive-score-committers. This must be intitiated via Eclipse Support. I am not sure they will do this, because in our current Teams are people without the committer status. So if we would grant these Teams write access this would somehow break the committer election process. I do not want to wait until this gets clarified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine from my side
3b2829d
to
695532e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put some changes to consider, quality and security not fully setup, shall we consider now or later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
# /integration_tests @eclipse-score/automotive-score-committers | ||
# /tools @eclipse-score/infrastructure-tooling-community | ||
# /docs/ @eclipse-score/community-process | ||
/docs/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/docs/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech | |
/docs/ @pahmann @PhilipPartsch @masc2023 @aschemmel-tech | |
/docs/conf.py @AlexanderLanin @MaximilianSoerenPollak @dcalavrezo-qorix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed
.github/CODEOWNERS
Outdated
/docs/contribute/ @eclipse-score/automotive-score-committers | ||
# /docs/features/ @eclipse-score/automotive-score-technical-leads | ||
/docs/features/ @antonkri @FScholPer @qor-lb @johannes-esr @markert-r | ||
_assets/ @eclipse-score/automotive-score-committers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means every committer can modify all assets regardless of the specific assignments made int this file so far. In this intentional?
E.g. every committer can modify images in features
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now I think of it, maybe you are right, I will remove this.
23e68e8
to
cd625d5
Compare
cd625d5
to
7255fab
Compare
No description provided.