+
Skip to content

Conversation

arsibo
Copy link
Contributor

@arsibo arsibo commented Jul 16, 2025

Copy link

The created documentation from the pull request is available at: docu-html

@arsibo arsibo marked this pull request as ready for review July 16, 2025 15:07
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment

Module
======

.. toctree::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the Headline in line 17 "Modules". And also rename the reference point in line 15 which is currently misleading (_modules_template) - the template is in the process_decription repository

@LittleHuba
Copy link
Contributor

Just a clarification statement, so that it is recorded for our ancestors.

As discussed in the architecture workshop this is just an intermediary step until we shift the modules to their actual repositories.

LittleHuba
LittleHuba previously approved these changes Jul 17, 2025
@arsibo
Copy link
Contributor Author

arsibo commented Jul 17, 2025

I forgot feo. I'll change the format in a way that it full fills the template and is equal between feo and com.

@arsibo arsibo changed the title communictaion: move modules to the rigth folder communictaion+feo: move modules to the rigth folder Jul 18, 2025
========
.. _comp_doc_json:

jscon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo -> json

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

aschemmel-tech
aschemmel-tech previously approved these changes Jul 22, 2025
Copy link
Contributor

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

-  move content from /docs/features/communication/modules to /docs/modules/
-  adaption to https://eclipse-score.github.io/process_description/main/folder_templates/modules/index.html
-  minor modifications of tracing component architecture
-  minor adjustments of headlines
@AlexanderLanin
Copy link
Member

sorry, i messed up the git consultation. force push follows in a minute. 😢

@arsibo arsibo force-pushed the arsibo_move_modules branch from a4349a4 to 69932fc Compare July 23, 2025 20:00
@arsibo arsibo requested a review from AlexanderLanin July 23, 2025 20:00
Copy link
Member

@AlexanderLanin AlexanderLanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only heading and toctrees changed. LGTM

@AlexanderLanin AlexanderLanin merged commit 160d47b into main Jul 23, 2025
8 checks passed
@AlexanderLanin AlexanderLanin deleted the arsibo_move_modules branch July 23, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载