+
Skip to content

Conversation

aschemmel-tech
Copy link
Contributor

No description provided.

@aschemmel-tech aschemmel-tech requested a review from PandaeDo July 14, 2025 14:38
@aschemmel-tech aschemmel-tech marked this pull request as draft July 14, 2025 14:38
@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-baselibs_asil-correct branch from 4dad958 to 90210a4 Compare July 15, 2025 09:04
@aschemmel-tech aschemmel-tech requested a review from 4og July 15, 2025 09:41
Copy link
Member

@4og 4og left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baselibs part looks good. Thank you.

Copy link
Contributor Author

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the changes in commit "lola: adapt ASIL Level for checks"

Copy link
Contributor

@PandaeDo PandaeDo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me

Copy link
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the latest released version

@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-baselibs_asil-correct branch from 3b5c7bf to 364cf8f Compare July 16, 2025 13:40
@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-baselibs_asil-correct branch from 364cf8f to 2fc0dc4 Compare July 16, 2025 13:45
Copy link

The created documentation from the pull request is available at: docu-html

@aschemmel-tech aschemmel-tech marked this pull request as ready for review July 16, 2025 14:52
@masc2023 masc2023 mentioned this pull request Jul 17, 2025
Copy link
Contributor

@ramceb ramceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor changes

:status: valid

The base libraries shall implement functionality necessary to support safety-relevant platform components up to ASIL-B.
The base libraries shall implement functionality necessary to support safety-relevant platform components up to ASIL-B for selected functionalities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The base libraries shall implement functionality necessary to support safety-relevant platform components up to ASIL-B for selected functionalities.
The base libraries shall implement functionality necessary to support safety-relevant platform components up to ASIL-B.

The additional restriction does not really add value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without the restriction all libraries functions would need ASIL B implementation and I think this is not planned. Merged nevertheless as this blocks some other PR work.

@masc2023
Copy link
Contributor

@aschemmel-tech , as some PR depends now on that, can we merge it?

@aschemmel-tech aschemmel-tech merged commit 416879f into main Jul 18, 2025
8 checks passed
@aschemmel-tech aschemmel-tech deleted the aschemmel-tech-baselibs_asil-correct branch July 18, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载